fix: path traversal guards, asset ifix: path traversal guards, ZIP integrity check, --max-length flag, engines field, testsntegrity, max-length flag, engines… - #348
Open
Spinulosa1111 wants to merge 1 commit into
Conversation
… field, tests Security: - design_system.py: sanitize --output-dir/--page/--project-name against path traversal via _sanitize_path_component() and _validate_output_dir() - extract.ts: assertSafeShellPath() rejects shell-special chars before execAsync - github.ts: verify ZIP magic bytes and log SHA256 after download (node:crypto) DX / quality: - search.py: --max-length/-l flag (default 300, 0=unlimited) - cli/package.json: add engines field (node >=18.0.0) - Remove cli/bun.lock (package-lock.json is canonical for npm) - Add tests/test_search.py: 30 unit tests for BM25, detect_domain, search shape, search_stack errors, and all path-sanitization attack vectors Synced all script changes to cli/assets/scripts/ per repo sync protocol. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
Author
|
Hey @nextlevelbuilder 👋 — I've submitted a batch of PRs that address several open issues and long-standing bugs. Here's a quick overview so you can review them together: Security & Core Fixes
CI / Workflows
Symlink Fix (root cause of install failures #347/#334)
Docs
Issue triage — Left repro-request/close comments on #337, #303, #305, #331, #335. Those can be closed at your discretion. Once the PRs are merged, tagging a |
3 tasks
mrgoonie
requested changes
Jun 20, 2026
mrgoonie
left a comment
mrgoonie
left a comment
Contributor
There was a problem hiding this comment.
Summary: This PR adds useful security/DX improvements around path handling, release ZIP validation, and search output length, but the bundled regression test suite currently fails as submitted.
Risk level: Medium
Mandatory gates:
- Duplicate/prior implementation: clear; GitHub search only found this PR for the path traversal / ZIP SHA256 / max-length scope.
- Project standards: checked against existing repo structure with source + cli/assets mirrors.
- Strategic necessity: clear value; this reduces install/search security risk and improves CLI DX.
- CI/checks: missing on the branch; I ran the included Python test file locally.
Findings:
- Critical: none.
- Important:
src/ui-ux-pro-max/scripts/tests/test_search.pyfails locally. Command:python3 src/ui-ux-pro-max/scripts/tests/test_search.py. Failure:TestBM25Tokenizer.test_filters_words_two_chars_or_lessexpectsBM25.tokenize("a is in the") == [], but the current tokenizer returns["the"]. Either update the test fixture to only use <=2-char words, or change the tokenizer intentionally and document why 3-char words should now be filtered too. - Suggestion: consider adding the same local test command to a lightweight CI check so future PRs do not rely on manual review to catch this.
Verdict: REQUEST_CHANGES
mrgoonie
added
agent:github-maintain
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--output-dir,--page,--project-nameindesign_system.py; shell-injection guard inextract.ts; ZIP magic-byte verification + SHA256 audit log ingithub.ts--max-length/-lflag onsearch.pymakes field truncation configurable (was hardcoded 300,0= unlimited)engines: node >=18.0.0inpackage.json;bun.lockremoved (duplicate ofpackage-lock.json); 30-test suite added atsrc/ui-ux-pro-max/scripts/tests/test_search.pyTest plan
python src/ui-ux-pro-max/scripts/tests/test_search.py— all non-data tests pass without CSV filespython search.py "test" --output-dir "../../etc" --persist→ exits with clear error, no file writtenpython search.py "glassmorphism" --max-length 0→ full field values, no truncationuipro init --legacystill works; bad ZIP download now fails fast with descriptive error